Drag But Not Drop Forum List

[Cdodds]

Phpbb version: 3.07-PL
Style: prosilver
Board: http://www.veinsfetiche.com/forums/

Problem: I installed drag and drop forums list, but the drop is not happening. It just sort of sticks to your mouse not matter what you do.

[EXreaction]

Works fine for me, what browser are you using?

[Cdodds]

IE 8.0, with google toolbar

What are you using?

[EXreaction]

Seems to be an issue with IE8, I use Firefox.

I would have to recommend you uninstall it and look for another similar modification to this, I know I've seen some in the past.

I will update the release topic to notify users of the problem.

[Cdodds]

My IE8 developers script console (Javascript Debugger) says that there is an "invalid argument" on this line:

Code: Select all

dragEvent.group.element.style.zIndex = originalZIndex

Within this block:

Code: Select all

onTopWhileDragging : function(zIndex) {
    var zIndex = typeof(zIndex) != "undefined" ? zIndex : 100000;
    originalZIndex = ToolMan.css().readStyle(this.element, "z-index")

    this.register('dragstart', function(dragEvent) {
      dragEvent.group.element.style.zIndex = zIndex
    })
    this.register('dragend', function(dragEvent) {
      dragEvent.group.element.style.zIndex = originalZIndex
    })
  },

I guess it is only logical though that the problem would be near "dragend".

What I do not get though, is that the same kind of argument is on this line:

Code: Select all

dragEvent.group.element.style.zIndex = zIndex

But...it runs that line just fine ^^

The main difference between the two lines is "zIndex" vs "originalZIndex"

I guess if we look at the difference between the vaules / types of those two symbols, we will figure out what IE8 does not like.

We know at those two lines:

Code: Select all

originalZIndex : 'auto'

Code: Select all

originalZIndex = ToolMan.css().readStyle(this.element, "z-index")

Code: Select all

var zIndex = typeof(zIndex) != "undefined" ? zIndex : 100000;

[EXreaction]

If you can figure out the problem I can update the install package.

[Cdodds]

This problem shall require a blood sacrifice to the all mighty oracle Google if we shall fix it!

~prepares sacrifice~

[10 minutes latter]

This seems to be a common problem with IE8: http://lmgtfy.com/?q=IE8+zindex+invalid+argument

This looks like a very similar problem: http://webcache.googleusercontent.com/s ... clnk&gl=us

[Cdodds]

First failed code change:

Code: Select all

dragEvent.group.element.style.zIndex = this.style.originalZIndex

The above does not work.

[Cdodds]

I found a fix!

Replace:

Code: Select all

  onTopWhileDragging : function(zIndex) {
    var zIndex = typeof(zIndex) != "undefined" ? zIndex : 100000;
    originalZIndex = ToolMan.css().readStyle(this.element, "z-index")

    this.register('dragstart', function(dragEvent) {
      dragEvent.group.element.style.zIndex = zIndex
    })
   
    this.register('dragend', function(dragEvent) {
      dragEvent.group.element.style.zIndex = originalZIndex
    })
  },

With:

Code: Select all

onTopWhileDragging: function(z) {
       
        // IE8 Modifications by Houlie
       
        var zIndex = typeof (z) != "undefined" ? z : 100000;
        var originalZIndex = ToolMan.css().readStyle(this.element, "z-index");
        if (typeof (originalZIndex) == "undefined") originalZIndex = ToolMan.css().readStyle(this.element, "zIndex");
        this.register('dragstart', function(e) { e.group.element.style.zIndex = zIndex; });
        this.register('dragend', function(e) { e.group.element.style.zIndex = originalZIndex;});
    },

Source of fix: http://blog.tool-man.org/drag-between-lists/12

How I found the fix: I googled "Tim Taylor" drag IE8 fix

[EXreaction]

The package has been updated.

viewtopic.php?f=31&t=496